From a495e5b2b9f02d6ba9dc1104abeff7f4518a4726 Mon Sep 17 00:00:00 2001 From: CarlWachter Date: Wed, 25 Sep 2024 17:50:34 +0200 Subject: [PATCH] Refactor CAN bus message queuing to pass by value --- include/sta/tacos/can_bus.hpp | 2 +- src/can_bus.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sta/tacos/can_bus.hpp b/include/sta/tacos/can_bus.hpp index 8117fbb..21e684e 100644 --- a/include/sta/tacos/can_bus.hpp +++ b/include/sta/tacos/can_bus.hpp @@ -61,7 +61,7 @@ namespace sta * @param timeout Timeout for placing message (0 = no wait, osWaitForever = blocking) * @return True if message was queued successfully */ - bool queueCanBusMsg(const CanSysMsg & msg, uint32_t timeout); + bool queueCanBusMsg(const CanSysMsg msg, uint32_t timeout); /** * @brief Retrieve system message from CAN driver TX queue. diff --git a/src/can_bus.cpp b/src/can_bus.cpp index 186870d..d9e69c6 100644 --- a/src/can_bus.cpp +++ b/src/can_bus.cpp @@ -79,7 +79,7 @@ namespace sta } } - bool CanBus::queueCanBusMsg(const CanSysMsg &msg, uint32_t timeout) + bool CanBus::queueCanBusMsg(const CanSysMsg msg, uint32_t timeout) { // This technically should check if we are using a system message, but we just pretending that everything is one of those rn // STA_ASSERT((msg.header.sid & ~STA_CAN_SID_SYS_BITS) == 0);